Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of top.location.href="..." or target="_top" in piwik ui #2516

Closed
anonymous-matomo-user opened this issue Jun 26, 2011 · 3 comments
Closed

remove use of top.location.href="..." or target="_top" in piwik ui #2516

anonymous-matomo-user opened this issue Jun 26, 2011 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone
1.5.1

Comments

@anonymous-matomo-user
Copy link

I spent a lot of time to integrate piwik into TYPO3.
But Piwik 1.5 seems to use either

top.location.href="..." or target="_top"

to enforce that piwik is not loaded in a frame.

This way the TYPO3 Backend is unloaded, while piwik loads in the top frame.

This behaviour is found on the settingspage. Please remove the following snippet!

    <script type="text/javascript"> 
        if(self == top) {
            var theBody = document.getElementsByTagName('body')[0];
            theBody.style.display = 'block';
        } else {
            top.location = self.location;
        }
    </script>

Thanks in advice.
@robocoder
Copy link
Contributor

Kay: this is part of the anti-clickjacking code. So, I can't remove it. However, it is configureable, albeit secure by default. If you want to frame logins or settings, you can set enabled_framed_logins = 0 and enable_framed_settings = 0, respectively. (See config/global.ini.php.)

@robocoder
Copy link
Contributor

Reference: CVE-2011-0399

@robocoder
Copy link
Contributor

Typo correction: I meant you have to set to = 1 to enable framing.

@anonymous-matomo-user anonymous-matomo-user added this to the 1.5.1 Piwik 1.5.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
3 participants
@mattab @robocoder @anonymous-matomo-user