Use proper base timestamp when setting cookie TTL #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PiwikTracker PHP class was using the createTs as a base for applying the cookie TTL offset instead of using the currentTs. This will result in cookie TTLs being in the past TTL seconds after the initial visitorId cookie is created. For example, 30 minutes after the initial visitorId cookie is set, all "ses" cookies will start getting set with expiration times in the past.
|
Nice find! Thanks for the PR and fix. |
mattab
pushed a commit
that referenced
this pull request
Mar 24, 2014
Use proper base timestamp when setting cookie TTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PiwikTracker PHP class was using the createTs as a base
for applying the cookie TTL offset instead of using the currentTs.
This will result in cookie TTLs being in the past TTL seconds
after the initial visitorId cookie is created. For example, 30
minutes after the initial visitorId cookie is set, all "ses"
cookies will start getting set with expiration times in the past.