Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public accessor Tracker.getRequest() for plugin needs #243

Closed
wants to merge 1 commit into from
Closed

Add public accessor Tracker.getRequest() for plugin needs #243

wants to merge 1 commit into from

Conversation

VincentLahaye
Copy link

Hi there!

I'm working on a plugin for piwik, and I need the function getRequest from the Tracker to be accessible publicly before pushing the plugin on the marketplace.

If you need more information about this plugin, feel free to send me a private message :)

Cheers,
Vincent.

@mattab
Copy link
Member

mattab commented Mar 23, 2014

Salut Vincent!

Nice to hear about your upcoming plugin.

by design getRequest was private because the function parameters could change, eg. we don't really use the parameter plugin and it could be removed later.

if we make getRequest public we could keep only the first two params request, customData

I think it would help to know a bit more about your plugin's use case?

@mattab
Copy link
Member

mattab commented Apr 7, 2014

@vlahaye let me know how you go, we could add the getRequest() method if that's easier to you. Cheers

@mattab
Copy link
Member

mattab commented May 9, 2014

Added the getRequest() method in http://dev.piwik.org/trac/ticket/5118
See commit: 8f4ab8c

I'm interested to hear and test your plugin as it sounds super useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants