@VincentLahaye opened this Pull Request on March 22nd 2014

Hi there!

I'm working on a plugin for piwik, and I need the function getRequest from the Tracker to be accessible publicly before pushing the plugin on the marketplace.

If you need more information about this plugin, feel free to send me a private message :)

Cheers,
Vincent.

@mattab commented on March 23rd 2014 Member

Salut Vincent!

Nice to hear about your upcoming plugin.

by design getRequest was private because the function parameters could change, eg. we don't really use the parameter plugin and it could be removed later.

if we make getRequest public we could keep only the first two params request, customData

I think it would help to know a bit more about your plugin's use case?

@mattab commented on April 7th 2014 Member

@vlahaye let me know how you go, we could add the getRequest() method if that's easier to you. Cheers

@mattab commented on May 9th 2014 Member

Added the getRequest() method in http://dev.piwik.org/trac/ticket/5118
See commit: https://github.com/piwik/piwik/commit/8f4ab8c0cb163a411eac27b33fdee8ffb69459d4

I'm interested to hear and test your plugin as it sounds super useful!

This Pull Request was closed on May 9th 2014
Powered by GitHub Issue Mirror