Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Expires: headers causes proxy cache to not cache the request #2406

Closed
mattab opened this issue May 5, 2011 · 4 comments
Closed

Empty Expires: headers causes proxy cache to not cache the request #2406

mattab opened this issue May 5, 2011 · 4 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented May 5, 2011

Since I have my current internet connection I have been VERY frustrated by the fact, that on the demo, none of the assets are cached and always return 200. What happens, is that my internet provider proxy cache didn't honor the cache headers.

After researching the cause is that the Expires: header is empty.

Setting the Expires: header in the far future (as advised by Yahoo best practises) fixes the issue and causes the proxy cache they use to finally cache our assets.

Setting expires in the far future, means that the file will not even be requested at all, so that the browser will only request in the far future.

However it should work nicely for us, because we use a buster in the assets URLs so that when the assets change, the <.. src='...'> URL is also changed (good call on this one anthon ;)

@mattab
Copy link
Member Author

mattab commented May 5, 2011

@robocoder
Copy link
Contributor

Should be ok in most cases. The only exception is the js/ proxy serving piwik.js which has no cache buster string.

@mattab
Copy link
Member Author

mattab commented May 5, 2011

(In [4642]) Fixes #2406

@mattab
Copy link
Member Author

mattab commented Mar 10, 2014

In c1703a1: cache /js/ for 10 days rather than none. Refs #2406
From forum feedback: http://forum.piwik.org/read.php?2,112741

@mattab mattab added this to the 1.5 - Piwik 1.5 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants