@mattab opened this Issue on May 1st 2011 Member

See example in forum

It is a small regression following recent fixes.

@sgiehl commented on May 4th 2011 Member

Guess the problem is here:

https://github.com/piwik/piwik/blob/master/plugins/Live/API.php#L308

If period is day it will always show the day before!

@peterbo commented on May 4th 2011 Contributor

PLease also refer to [http://forum.piwik.org/read.php?5,76195] - I already had a talk with Matt about this statement. It seems like deleting the "->subDay(1)" call would rise another issue.

@mattab commented on May 16th 2011 Member

I have commmitted a patch for this issue, see the few lines following: https://github.com/piwik/piwik/blob/master/plugins/Live/API.php#L372

I haven't tested much, in particular with timezones like GMT-8 and GMT+8 but these few lines should help

@mattab commented on May 17th 2011 Member

(In [4710]) Fixes #2387 - test is most welcome!

@anonymous-piwik-user commented on May 20th 2011

Thanks for the fix, but I'd like to know if it is ok just overwrite the stock file(API.php) with the trunk.

In stock 1.4, the "->subday(1)" makes errors on day/week/month/year selection on specific dates in Visitor Log page, please check my test result on (note: user-defined range does not have errors)
http://forum.piwik.org/read.php?2,76196,page=1#msg-77084

@mattab commented on May 20th 2011 Member

It's not going to work to reuse the API.php file like this, but you can just try to change the IF block that starts at line: https://github.com/piwik/piwik/blob/master/plugins/Live/API.php?rev=4710#L375 then it should work with 1.4

Your tests are very appreciated.. I am not 100% sure that all issues are fixed!

@anonymous-piwik-user commented on May 21st 2011

so far so good it seems to have fixed my issues will report back if I find anything.

This Issue was closed on May 21st 2011
Powered by GitHub Issue Mirror