Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Screenshot Test refactor + many new tests #235

Merged
merged 115 commits into from Mar 6, 2014
Merged

UI Screenshot Test refactor + many new tests #235

merged 115 commits into from Mar 6, 2014

Conversation

diosmosis
Copy link
Member

Iffy commits & changes:

  • TestingEnvironment.addHooks event (see use in DBStats plugin)
  • commit 0195bb5 . Used to get Installation_spec.js test to work. Originally, FrontController::createConfigObject would never throw since the local INI file is never checked for readability.

diosmosis added 30 commits February 20, 2014 05:55
- Rename *_BaseFixture to Fixture.
- Move DB setup code to Fixture and reuse code in DatabaseTestCase.
- Make IntegrationTestCase::$defaultApiNotToCall an instance var.
…ion and modified screenshot capture script to automatically wait after sending each event.

Notes:

  - Modify DbHelper::createAnonymousUser to add only if user does not already exist.
  - Allow config to be overridden by file in tmp dir during tests.
Conflicts:
	tests/PHPUnit/IntegrationTestCase.php
- Modify test user adding logic to hash password instead of using pre-hashed password.
- Allow testing environment to be configured via Option values that start w/ 'Tests.'.
- Put a couple test classes into namespaces. Add test event to Piwik\Mail class so emails can be intercepted.
- Change some test logging level to INFO.
- Added load + reload methods to PageFacade in capture.js
…aced OmniFixture into a namespace, removed PHP screenshot testcase classes and added fixture for use w/ JavaScript screenshot tests.
Conflicts:
	tests/PHPUnit/UI
diosmosis added 18 commits March 4, 2014 10:37
…eenshot testing code and display location hint in diffviewer output if expected file is stored within plugin and not the UI tests repo.
…-store-in-ui-tests-repo, --use-github-expected.
Conflicts:
	tests/PHPUnit/Integration/BlobReportLimitingTest.php
	tests/PHPUnit/IntegrationTestCase.php
	tests/PHPUnit/UI
…testing config to README and remove unused constant from Config.php.
Conflicts:
	piwik.js
	plugins/SegmentEditor/javascripts/Segmentation.js
$this->metadataProvider = new MySQLMetadataProvider();
if ($this->metadataProvider === null) {
$this->metadataProvider = new MySQLMetadataProvider();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this if statement helping or maybe it's not needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

mattab pushed a commit that referenced this pull request Mar 6, 2014
UI Screenshot Test refactor + many new tests
@mattab mattab merged commit b413d2c into master Mar 6, 2014
@mattab
Copy link
Member

mattab commented Mar 6, 2014

What an Epic pull request!!
we now have amazing test coverage of the UI. We have become so much more agile!

Such a job well done... 🎱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants