New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Screenshot Test refactor + many new tests #235
Conversation
- Rename *_BaseFixture to Fixture. - Move DB setup code to Fixture and reuse code in DatabaseTestCase. - Make IntegrationTestCase::$defaultApiNotToCall an instance var.
…ion and modified screenshot capture script to automatically wait after sending each event. Notes: - Modify DbHelper::createAnonymousUser to add only if user does not already exist. - Allow config to be overridden by file in tmp dir during tests.
Conflicts: tests/PHPUnit/IntegrationTestCase.php
- Modify test user adding logic to hash password instead of using pre-hashed password. - Allow testing environment to be configured via Option values that start w/ 'Tests.'. - Put a couple test classes into namespaces. Add test event to Piwik\Mail class so emails can be intercepted. - Change some test logging level to INFO. - Added load + reload methods to PageFacade in capture.js
… --persist-fixture-data is used.
Conflicts: tests/PHPUnit/UI
…eenshot testing code and display location hint in diffviewer output if expected file is stored within plugin and not the UI tests repo.
…-store-in-ui-tests-repo, --use-github-expected.
Conflicts: tests/PHPUnit/Integration/BlobReportLimitingTest.php tests/PHPUnit/IntegrationTestCase.php tests/PHPUnit/UI
…uild timeout on travis.
…testing config to README and remove unused constant from Config.php.
…ecified to screenshot test runner script.
Conflicts: piwik.js plugins/SegmentEditor/javascripts/Segmentation.js
$this->metadataProvider = new MySQLMetadataProvider(); | ||
if ($this->metadataProvider === null) { | ||
$this->metadataProvider = new MySQLMetadataProvider(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this if statement helping or maybe it's not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
UI Screenshot Test refactor + many new tests
What an Epic pull request!! Such a job well done... 🎱 |
Iffy commits & changes: