New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiSites module should have a Totals Line displayed at the bottom #2349
Comments
Attachment: |
Please review the attached files. I have only included the files that needed updated to add this feature. This modification is in response to the forum request for a "Total data of all websites" posted by izarco on 4/5/2011. |
jstock, can you please submit a patch for the modification? see the doc: http://piwik.org/participate/development-process/#toc-how-to-submit-a-patch Thanks |
Attachment: |
added the patch file, however please notice that there is a new file that has been added to this pluggin also. Please review |
Thanks jstock, code looks OK - can you please confirm, that you have tested with more than 20 websites, when pagination mode is on? the Total row should always stay at the bottom. Also, can you please post a screenshot? def keen to commit this to core! |
Attachment: MultiSites Zip File |
Attachment: Patch File |
I have attached a couple new files the first is a new zip file with a few changes. The second is a copy of the patch file, Please note that the total.tpl still needs to be manually copied to the templates folder. I have tested this with 22 sites and the total line stays in place at the bottom. Also of note is that even when reordering by any column the total line stays at the bottom. |
Attachment: |
What's the fireshot capture for? For multi-page, is that a grand total, or subtotal for a page? |
Sorry uploaded the wrong second file, I will upload the correct one. |
Attachment: |
OK looking good thanks! we might just have to put a top border to show that it is not a normal website, but that's cool |
Matt, if you would like me to update anything in this code please let me know, or if you have other enhancements that you would like I would be happy to help out with them. |
I think it looks good, thanks we will commit it for the next release |
will this be in the betas / RC as well? can't wait to get this... :) |
Will we see this in 1.5? It would be great |
the patch submitted does NOT work. please TEST before submitting a patch! it throws parse errors and templates errors. Im talking about this patch: http://issues.piwik.org/attachments/2349/MultiSites.patch because the next patch you submitted, is not related to the issue described here. |
Add a TOTALS line at the bottom of the page for the MultiSites plugin.
The text was updated successfully, but these errors were encountered: