Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSites module should have a Totals Line displayed at the bottom #2349

Closed
anonymous-matomo-user opened this issue Apr 21, 2011 · 20 comments
Closed
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@anonymous-matomo-user
Copy link

Add a TOTALS line at the bottom of the page for the MultiSites plugin.

@anonymous-matomo-user
Copy link
Author

Attachment:
MultiSites.zip

@anonymous-matomo-user
Copy link
Author

Please review the attached files. I have only included the files that needed updated to add this feature. This modification is in response to the forum request for a "Total data of all websites" posted by izarco on 4/5/2011.
I would be happy to help with this issue and any others that you would like me to work on.
Any feedback given would be appreciated.

@mattab
Copy link
Member

mattab commented Apr 23, 2011

jstock, can you please submit a patch for the modification? see the doc: http://piwik.org/participate/development-process/#toc-how-to-submit-a-patch

Thanks

@anonymous-matomo-user
Copy link
Author

Attachment:
MultiSites.patch

@anonymous-matomo-user
Copy link
Author

added the patch file, however please notice that there is a new file that has been added to this pluggin also.
MultiSites/templates/total.tpl

Please review

@mattab
Copy link
Member

mattab commented Apr 28, 2011

Thanks jstock, code looks OK - can you please confirm, that you have tested with more than 20 websites, when pagination mode is on? the Total row should always stay at the bottom. Also, can you please post a screenshot? def keen to commit this to core!

@anonymous-matomo-user
Copy link
Author

Attachment: MultiSites Zip File
MultiSites.2.zip

@anonymous-matomo-user
Copy link
Author

Attachment: Patch File
MultiSitesTL.patch

@anonymous-matomo-user
Copy link
Author

I have attached a couple new files the first is a new zip file with a few changes. The second is a copy of the patch file, Please note that the total.tpl still needs to be manually copied to the templates folder.

I have tested this with 22 sites and the total line stays in place at the bottom. Also of note is that even when reordering by any column the total line stays at the bottom.
Please see the 2 attached png files.

@anonymous-matomo-user
Copy link
Author

Attachment:
MultiSitesPage1.png

@anonymous-matomo-user
Copy link
Author

@robocoder
Copy link
Contributor

What's the fireshot capture for?

For multi-page, is that a grand total, or subtotal for a page?

@anonymous-matomo-user
Copy link
Author

Sorry uploaded the wrong second file, I will upload the correct one.
The total line is a grand total not a subtotal, if you want a subtotal I will have to look at that as an option but think that it could be done.

@anonymous-matomo-user
Copy link
Author

Attachment:
MultiSitesPage2.png

@mattab
Copy link
Member

mattab commented Apr 28, 2011

OK looking good thanks! we might just have to put a top border to show that it is not a normal website, but that's cool

@anonymous-matomo-user
Copy link
Author

Matt, if you would like me to update anything in this code please let me know, or if you have other enhancements that you would like I would be happy to help out with them.

@mattab
Copy link
Member

mattab commented May 10, 2011

I think it looks good, thanks we will commit it for the next release

@anonymous-matomo-user
Copy link
Author

will this be in the betas / RC as well? can't wait to get this... :)

@anonymous-matomo-user
Copy link
Author

Will we see this in 1.5? It would be great

@mattab
Copy link
Member

mattab commented May 30, 2011

the patch submitted does NOT work. please TEST before submitting a patch!

it throws parse errors and templates errors. Im talking about this patch: http://issues.piwik.org/attachments/2349/MultiSites.patch

because the next patch you submitted, is not related to the issue described here.

@anonymous-matomo-user anonymous-matomo-user added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants