@anonymous-piwik-user opened this Issue on April 21st 2011

Add a TOTALS line at the bottom of the page for the MultiSites plugin.

@anonymous-piwik-user commented on April 21st 2011

Attachment:
MultiSites.zip

@anonymous-piwik-user commented on April 25th 2011

Attachment:
MultiSites.patch

@anonymous-piwik-user commented on April 28th 2011

Attachment: MultiSites Zip File
MultiSites.2.zip

@anonymous-piwik-user commented on April 28th 2011

Attachment: Patch File
MultiSitesTL.patch

@anonymous-piwik-user commented on April 28th 2011

Attachment:
MultiSitesPage1.png

@anonymous-piwik-user commented on April 28th 2011

Attachment:
[FireShot capture #238 - 'Query Tool' - narmada_tapdev_com_tools_querytool_php.png](http://issues.piwik.org/attachments/2349/FireShot_capture_#238-'QueryTool'-_narmada_tapdev_com_tools_querytool_php.png)

@anonymous-piwik-user commented on April 28th 2011

Attachment:
MultiSitesPage2.png

@anonymous-piwik-user commented on April 21st 2011

Please review the attached files. I have only included the files that needed updated to add this feature. This modification is in response to the forum request for a "Total data of all websites" posted by izarco on 4/5/2011.
I would be happy to help with this issue and any others that you would like me to work on.
Any feedback given would be appreciated.

@mattab commented on April 23rd 2011 Member

jstock, can you please submit a patch for the modification? see the doc: http://piwik.org/participate/development-process/#toc-how-to-submit-a-patch

Thanks

@anonymous-piwik-user commented on April 25th 2011

added the patch file, however please notice that there is a new file that has been added to this pluggin also.
MultiSites/templates/total.tpl

Please review

@mattab commented on April 28th 2011 Member

Thanks jstock, code looks OK - can you please confirm, that you have tested with more than 20 websites, when pagination mode is on? the Total row should always stay at the bottom. Also, can you please post a screenshot? def keen to commit this to core!

@anonymous-piwik-user commented on April 28th 2011

I have attached a couple new files the first is a new zip file with a few changes. The second is a copy of the patch file, Please note that the total.tpl still needs to be manually copied to the templates folder.

I have tested this with 22 sites and the total line stays in place at the bottom. Also of note is that even when reordering by any column the total line stays at the bottom.
Please see the 2 attached png files.

@robocoder commented on April 28th 2011 Contributor

What's the fireshot capture for?

For multi-page, is that a grand total, or subtotal for a page?

@anonymous-piwik-user commented on April 28th 2011

Sorry uploaded the wrong second file, I will upload the correct one.
The total line is a grand total not a subtotal, if you want a subtotal I will have to look at that as an option but think that it could be done.

@mattab commented on April 28th 2011 Member

OK looking good thanks! we might just have to put a top border to show that it is not a normal website, but that's cool

@anonymous-piwik-user commented on May 5th 2011

Matt, if you would like me to update anything in this code please let me know, or if you have other enhancements that you would like I would be happy to help out with them.

@mattab commented on May 10th 2011 Member

I think it looks good, thanks we will commit it for the next release

@anonymous-piwik-user commented on May 10th 2011

will this be in the betas / RC as well? can't wait to get this... :)

@anonymous-piwik-user commented on May 24th 2011

Will we see this in 1.5? It would be great

@mattab commented on May 30th 2011 Member

the patch submitted does NOT work. please TEST before submitting a patch!

it throws parse errors and templates errors. Im talking about this patch: http://issues.piwik.org/attachments/2349/MultiSites.patch

because the next patch you submitted, is not related to the issue described here.

This Issue was closed on October 19th 2011
Powered by GitHub Issue Mirror