Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunk: CSRF Protection Bypass #2313

Closed
robocoder opened this issue Apr 14, 2011 · 0 comments
Closed

trunk: CSRF Protection Bypass #2313

robocoder opened this issue Apr 14, 2011 · 0 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone
1.6

Comments

@robocoder
Copy link
Contributor

This ticket is to investigate and correct any issues similar to those identified in:

A cursory inspection shows:

  • Piwik does not use the X-Requested-With header to automatically trust requests
  • Piwik does use nonces as a CSRF protection on POST forms and token auth for AJAX

We already did an audit (and internal review) for 1.1, but a lot has changed since then, so it might be prudent to give the APIs and Controllers a 2nd look.
@robocoder robocoder added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
1 participant
@robocoder