Suggested change to increase the security of the login form. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm :+1 for this! |
|
Thanks for the suggestion! it makes 100% sense for the password reminder fields and is in fact a must for these. For the first one though, I'm not convinced. There seems to be a lot of people arguing against this measure as it breaks the usability of password managers. So I will push the last two autocomplete=off and not first one. For more info on the pros/cons see: https://startpage.com/do/search?q=autocomplete%3Doff%20security |
mattab
added a commit
that referenced
this pull request
Feb 25, 2014
…hat the password are not auto-completed there. did not add it to main password field as to not break the password manager /browser functionnality.
tehnotronic
added a commit
to matomo-org/plugin-LoginLdap
that referenced
this pull request
Feb 25, 2014
…eset form so that the password are not auto-completed there.
|
FYI: because this is actually a great feature request that could be done as a config setting i've reopened an issue for it: New config setting to set autocomplete=off to password fields in Piwik #6347 Feel free to suggest pull request 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.