Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunk: class hierachy, phpdocs, and unit test dev issues #2256

Closed
robocoder opened this issue Apr 3, 2011 · 10 comments
Closed

trunk: class hierachy, phpdocs, and unit test dev issues #2256

robocoder opened this issue Apr 3, 2011 · 10 comments
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
1.3

Comments

@robocoder
Copy link
Contributor

unit tests:

  • all_tests.php appears to have truncated the tables in my database (instead of database_tests)

class hierarchy:

  • inconsistency in interface classes (naming and location)

phpdocs:

  • classes, functions, and files missing, e.g., core/PluginsFunctions/
  • can we add the Piwik version number?
  • documentation license?
@robocoder
Copy link
Contributor Author

(In [4295]) refs #2256 - unit tests: always setTestEnvironment()

@robocoder
Copy link
Contributor Author

(In [4297]) refs #2256

@robocoder
Copy link
Contributor Author

(In [4298]) refs #2256 - remove my @author tags; these don't render correctly in phpdocs anyways

@robocoder
Copy link
Contributor Author

(In [4299]) refs #2256 - remove @Version tags from the function-level phpdocs

@robocoder
Copy link
Contributor Author

(In [4302]) refs #2256 - some phpdocs love

@robocoder
Copy link
Contributor Author

(In [4311]) fixes #2256 - missing data type in phpdocs, e.g., @param $name

@robocoder
Copy link
Contributor Author

The "missing" classes/functions/files can be found by clicking on the dropdown in the top right of the window.

No, we can't add the version number. The banner uses the @Package name.

And no, there's no facility to add a reference to a documentation license.

@robocoder
Copy link
Contributor Author

(In [4312]) refs #2256 - more invalid tags

@mattab
Copy link
Member

mattab commented Apr 4, 2011 

all_tests.php appears to have truncated the tables in my database (instead of database_tests)

It seems it doesn't do it anymore?

@robocoder
Copy link
Contributor Author

Can't reproduce it. Maybe I fat-fingered the db name during my testing?

@robocoder robocoder added this to the Piwik 1.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@mattab @robocoder