Added a setSiteAliasUrls method to the SitesManager API #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method works in a similar way to the addSiteAliasUrls method, but it completely overwrites the URL list rather than merely adding to it.
mattab
pushed a commit
that referenced
this pull request
Feb 6, 2014
Added a setSiteAliasUrls method to the SitesManager API. Thanks for the Pull request!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method works in a similar way to the addSiteAliasUrls method, but it completely overwrites the URL list rather than merely adding to it.
My use case: my site has an admin system where aliases can be added and removed by the users, and we need to update Piwik's alias list automatically. It's far easier to simply send over an API request containing the full list every time than to use the "add" method. The other option would be to use updateSite, but that means getting all the other data required by updateSite to send back.