Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions Pages - URL inconsistencies #2207

Closed
robocoder opened this issue Mar 19, 2011 · 2 comments
Closed

Actions Pages - URL inconsistencies #2207

robocoder opened this issue Mar 19, 2011 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.

Comments

@robocoder
Copy link
Contributor

Handling the scheme/protocol is buggy:

  • the link.gif icon is displayed for "file:" or anything that looks like a script protocol (i.e., javascript|vbscript|jscript|mocha|livescript|ecmascript)
  • we should instead display no icon or an alternate icon (e.g., blank or a circle with a slash through it, to indicate it isn't clickable)

The following URLs:

http://www.example.com/A/B
/A/C
http://example.com/A/D
ftp://example.com/A/E
file://example.com/A/F
javascript:alert()

Appear in the UI as:

- A
  > /B - links to http://www.example.com/A/B
  > /C - links to http:///A/C (WRONG)
  > /D - links to http://example.com/A/D
- file:
  - example.com
    - A
      > /F - links to http://file//example.com/A/F (WRONG)
> /javascript:alert() (UGLY but is properly escaped)
- ftp:
  - example.com
    - A
      > /E - links to ftp://example.com/A/E

Also, according to #2731, non-http links are no longer tracked. This is an undocumented compat buster since there's no obvious mention in the 1.6 changelog.

The proposed workaround is also kind of fugly. It would be nicer if a plugin could rewrite URLs rather than telling users to fake it.

Also, r5356 introduced a protocol (i.e., mailto) filter in piwik.js in a regex intended to filter out only javascript.

Proposal:

  • make it configureable on the server as to what protocols can be tracked (to avoid unnecessary logging)
  • in piwik.js make it configureable as to what protocols can be tracked (to avoid unnecessary requests)
  • resolve above display inconsistencies
@mattab
Copy link
Member

mattab commented Sep 17, 2011

I think these are acceptable display bugs, maybe in fact piwik should not track any of these by default, but always good to know people copy your content on their hard drive or ftp ;)

@mattab
Copy link
Member

mattab commented Jan 13, 2014

please reopen if you care about this, with a screenshot showing the issue? thanks!

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

2 participants