Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding errors in language files #2202

Closed
mattab opened this issue Mar 18, 2011 · 4 comments
Closed

Encoding errors in language files #2202

mattab opened this issue Mar 18, 2011 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.3

Comments

@mattab
Copy link
Member

mattab commented Mar 18, 2011

The French language file in 1.2.1 contains encoded entities:

 d'entrer ```

It might be because on my windows box (which I use to grab the cleaned translation files after the unit test languagesManager.test.php has ran) the addcslashes or something else encodes these entities.


The other problem is the failing test, which doesn't fail on my box 
http://qa.piwik.org:8080/webtest/003_UnitTests/001_response_invoke.html

Proposed solution: the languages manager test should remove entities from the language files when cleaning them up before the release.
@robocoder
Copy link
Contributor

The first problem: a change in TranslationsAdmin or how you get the original translation files from Noah?

The second problem: I didn't figure out the cause but I'll merge my "tidy" code into the LanguagesManager and TranslationsAdmin.

@mattab
Copy link
Member Author

mattab commented Mar 20, 2011

(In [4149]) Fixes #2202 Now converting all entities to their characters when cleaning up translation files before release

One side effect is that & is now & only (which I rememberr fails W3C recommendations... but hey at least it's working!

@robocoder
Copy link
Contributor

(In [4154]) refs #2202 - debug failing unit test

@robocoder
Copy link
Contributor

(In [4155]) refs #2202 - more debug

@mattab mattab added this to the Piwik 1.3 milestone Jul 8, 2014
@robocoder robocoder mentioned this issue Mar 27, 2011
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@mattab @robocoder