Regression in menu code: double click show orange warning message #2180

If you click on dashboard, in the menu, more than once, the orage warning message says "Oops problem during the request, please try again." and fades out 2s later, after the content loaded, (causing the page to jump). I'm pretty sure this is a regression.

Solution: 2 clicks on the same menu /submenu should not trigger more than 1 ajax requests...

The problem is, that the first request is aborted, resulting in the error message to be displayed. Maybe hiding the error message on starting the new request could fix the issue.

Adding a

piwikHelper.hideAjaxError('loadingError');

at the beginning of broadcast.loadAjaxContent should help.

(In [4148]) Fixes #2180 Kuddos SteveG!

The message still shows when we click on top right "Settings" while dashboard widgets still loading... but I'm not sure how we could prevent this one (or that it matters so much)