Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made file integrity warning completely translatable #216

Merged
merged 1 commit into from Jan 31, 2014

Conversation

craue
Copy link
Contributor

@craue craue commented Jan 31, 2014

No description provided.

@sgiehl
Copy link
Member

sgiehl commented Jan 31, 2014

Thanks for your pull request. Unfortunately we can't merge it that way.
Please do not make changes to existing translations. Instead it would be better to create a new key for the missing part. Otherwise it would be missing in all other languages. Additionally we won't merge pull requests for translation files other than en.json. All changes done to other files will be overwritten as soon as we push our translations from http://translations.piwik.org

@craue
Copy link
Contributor Author

craue commented Jan 31, 2014

I expected a reaction like that. 😏 How shall I name the new key, "General_WarningFileIntegrityNoManifestDeployingFromGit"?

@sgiehl
Copy link
Member

sgiehl commented Jan 31, 2014

Sounds ok. Don't have a better name for it ;)

@craue
Copy link
Contributor Author

craue commented Jan 31, 2014

Should be fine now.

sgiehl pushed a commit that referenced this pull request Jan 31, 2014
made file integrity warning completely translatable
@sgiehl sgiehl merged commit a0f1b69 into matomo-org:master Jan 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants