@robocoder opened this Issue on March 4th 2011 Contributor

These issues are intertwined. I think we should refactor the Live plugin and add some much needed unit tests.

Timezone:

Export limits:

@anonymous-matomo-user commented on March 5th 2011

Confirmed, regression of #1458 again

@robocoder commented on March 5th 2011 Contributor

IIRC this was to fix a problem when the period != 'day'.

@mattab commented on March 11th 2011 Member

See proposed patch in: http://forum.piwik.org/read.php?2,72889,page=1#msg-72911

/piwik/plugins/Live/API.php you will find on about line 240:
- $processedDate = Piwik_Date::factory($date, $currentTimezone);// if not commented, the Period below fails ->setTimezone($currentTimezone);
+ $processedDate = Piwik_Date::factory($date)->setTimezone($currentTimezone);
@mattab commented on March 26th 2011 Member

(In [4188]) Refs #572

  • Adding Date Range calendar UI, with "Apply Date Range" button. Possibility to edit the INPUT fields directly rather than clicking in the calendar. Testing that dates are valid (from < to, valid string).
  • Updating calendar to show Loading.. on click (hopefully it makes it less confusing)
  • Fixing few bugs when period=range
  • All reports should load correctly when period=range, including sparklines, graphs & standard tables
  • Refs #2145 renaming parameter to $filter_limit which seems to work OK - it's not even a hack isn't it? :)
    TODO:
  • refactor period_select.tpl JS in helper,
  • Metadata compatibility with period=range (at least the World map doesn't work for now)
  • previous TODO still valid

Testing is welcome, please report any bug you find!

@mattab commented on March 26th 2011 Member
@anonymous-matomo-user commented on March 26th 2011

This change resolved my issue with incorrectly processed time zones.

@mattab commented on April 5th 2011 Member

(In [4316]) Fixes #2145 as far as I can see, it should be fixed, but I've been wrong all previous times so testing is very much welcome! thx

Refs #1966 Improving visitor log performance by rewriting the query

This Issue was closed on April 5th 2011
Powered by GitHub Issue Mirror