New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to DevicesDetection plugin #213
Conversation
…tters before the searched regex as there are many incorrect detected devices otherwise (eg. searching for LG phones with 'LG' only also matched 'Coolgen E70')
…nt like pt-br or pt-pt should not be detected as pantech device
…be used in case insensitive mode; see UserAgentParserEnhanced::matchUserAgent
…(like Xbox) won't be detected
…er; added more tests
… browser; improved several detections
I'll merge that pull request now. There are already a lot of improvements in it. |
refs #4215 #3505 Improvements to DevicesDetection plugin
Excellent work Stefan! I plan to put some work into this to place some extension points to the Device Detection and some settings. I think this will lead into the opposite direction regarding the optimisation efforts discussed here, but we need some tweaks to use the full potential of piwik and would take the downside of this. Just a few Examples:
Any thoughts on this? Should i file this somewhere else since a closed pull request dosn't some the right place to discuss these additions. |
The next step will be to combine UserSettings and DevicesDetection plugins and to enable it by default. |
Could anyone please have a closer look before merging? Thx.