New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refs #4564 #2589 support for multi superuser #212
Conversation
… user is superuser. Reload page after successfully changing superuser permission to make sure it is afterwards possible to (edit / not edit) websites permissions
…access. Old methods will still work but are marked as deprecated and they will be removed in a future release
…. Old methods will still work but are marked as deprecated and they will be removed in a future release
…re as promised and removed afterwards
…probably) and renamed more methods
Conflicts: plugins/CustomAlerts plugins/SegmentEditor/API.php
… access will be authenticated as super user
…s and updated some test names
Conflicts: plugins/CustomAlerts
Can we in future rebase/squash all those commits down to a reasonable number? It's becoming incredibly difficult to follow what has changed. |
$superUserPassword = Config::getInstance()->superuser['password']; | ||
if (md5($superUserLogin . $superUserPassword) === $tokenAuth) { | ||
|
||
Piwik::postEvent('Request.initAuthenticationObject'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to result in an fatal error in some cases. VisitorGenerator plugin doesn't work anymore.
PHP Fatal error: Class 'Piwik\\Plugins\\Login\\Auth' not found in /var/www/piwik/plugins/Login/Login.php on line 69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just committed a fix. Wondering why we are not using the Autoloader in piwik.php (the tests do load it)? Performance? I added the autoloader to piwik.php but remove it again in case this is a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just created a ticket to use autoloader in piwik.php tracker requests: http://dev.piwik.org/trac/ticket/4599#ticket
would be nice to have indeed!
No description provided.