Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #4564 #2589 support for multi superuser #212

Merged
merged 52 commits into from Jan 28, 2014
Merged

refs #4564 #2589 support for multi superuser #212

merged 52 commits into from Jan 28, 2014

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 28, 2014

No description provided.

… user is superuser. Reload page after successfully changing superuser permission to make sure it is afterwards possible to (edit / not edit) websites permissions
…access. Old methods will still work but are marked as deprecated and they will be removed in a future release
…. Old methods will still work but are marked as deprecated and they will be removed in a future release
Conflicts:
	plugins/CustomAlerts
	plugins/SegmentEditor/API.php
… access will be authenticated as super user
tsteur added a commit that referenced this pull request Jan 28, 2014
@tsteur tsteur merged commit dabec29 into master Jan 28, 2014
@halfdan
Copy link
Member

halfdan commented Jan 28, 2014

Can we in future rebase/squash all those commits down to a reasonable number? It's becoming incredibly difficult to follow what has changed.

$superUserPassword = Config::getInstance()->superuser['password'];
if (md5($superUserLogin . $superUserPassword) === $tokenAuth) {

Piwik::postEvent('Request.initAuthenticationObject');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to result in an fatal error in some cases. VisitorGenerator plugin doesn't work anymore.
PHP Fatal error: Class 'Piwik\\Plugins\\Login\\Auth' not found in /var/www/piwik/plugins/Login/Login.php on line 69

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just committed a fix. Wondering why we are not using the Autoloader in piwik.php (the tests do load it)? Performance? I added the autoloader to piwik.php but remove it again in case this is a problem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just created a ticket to use autoloader in piwik.php tracker requests: http://dev.piwik.org/trac/ticket/4599#ticket
would be nice to have indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants