Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore RFC1918 proxy client IP addresses #2077

Closed
anonymous-matomo-user opened this issue Feb 9, 2011 · 5 comments
Closed

Ignore RFC1918 proxy client IP addresses #2077

anonymous-matomo-user opened this issue Feb 9, 2011 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone
1.2

Comments

@anonymous-matomo-user
Copy link

When a client with a private IP address logs its visit through a proxy, the private IP address is logged, but not the proxy address that will be much more precious: a visitor log showing an IP address as 192.168.x.x is not very useful...

The attached patch directs Piwik to ignore proxy client IP addresses belonging to private networks, thus replacing them in the log by the true proxy address.
@anonymous-matomo-user
Copy link
Author

Attachment: Patch as described. For Piwik 1.1.1.
piwik-1.1.1-rfc1918.patch

@robocoder
Copy link
Contributor

You should be defining the proxy_client_headers[and proxy _host_headers to get the desired effect. See config/global.ini.php.

@anonymous-matomo-user
Copy link
Author

Not exactly: what you propose is a global filtering on the headers NAME. I want to enable those, but filter on their VALUE: I don't like to see RFC1918 addresses in the visitor log...

@robocoder
Copy link
Contributor

You'll be able to do this kind of filtering via #2055. This is now planned for 1.3.

@anonymous-matomo-user
Copy link
Author

Thanks for your reply. Will check in 1.3 ... impatiently awaited.

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 1.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
3 participants
@mattab @robocoder @anonymous-matomo-user