Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing PEAR.php path so that the GeoIP untar can function properly witho... #207

Closed
wants to merge 2 commits into from
Closed

Fixing PEAR.php path so that the GeoIP untar can function properly witho... #207

wants to merge 2 commits into from

Conversation

jloh
Copy link

@jloh jloh commented Jan 22, 2014

...ut needing php-pear to be installed - bug #4533

Fixing PEAR.php path so that the GeoIP untar can function properly wi…
82c4fa3 
…thout needing php-pear to be installed - bug #4533
@halfdan
Copy link
Member

halfdan commented Jan 22, 2014

Hi @MooASh,
thank you for the PR. Sadly this breaks the build: https://travis-ci.org/piwik/piwik/jobs/17398838#L190. Can you update your PR?

@jloh
Copy link
Author

jloh commented Jan 22, 2014

I apologise, I'm still learning to code. I've just used your code from your comment.

@halfdan
Copy link
Member

halfdan commented Jan 22, 2014

Thanks - I manually merged and fixed a remaining issue. Commited it here: 4d835a1

@halfdan halfdan closed this Jan 22, 2014
@jloh jloh mentioned this pull request Jan 22, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jloh @halfdan