Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from reading raw config values to PrivacyManager::getPurgeDataS... #206

Merged
merged 3 commits into from Jan 23, 2014
Merged

Switched from reading raw config values to PrivacyManager::getPurgeDataS... #206

merged 3 commits into from Jan 23, 2014

Conversation

clearcode
Copy link

...ettings() so if PiwikOption holds different configuration than config file it, proper values are taken to calculations.

How to reproduce original error:

  • Enable log deleting in config.ini.php with small interval (i.e. 1 day)
  • override those options via UI with bigger interval (i.e. 90 days)
  • try to use invalidateArchivedReports() method with date between 1 and 90 days back from today - it will cause warning and reports for given date will not be invalidated even though they actually could be.

This patch fixes this behaviour so the same dates are being considered in both places.

mattab and others added 3 commits January 22, 2014 17:32
…taSettings() so if PiwikOption holds different configuration than config file it, proper values are taken to calculations
mattab pushed a commit that referenced this pull request Jan 23, 2014
…idateArchivedReports

Switched from reading raw config values to reusing the helper method, fixes #4568
@mattab mattab merged commit 2d41d1e into matomo-org:master Jan 23, 2014
@mattab
Copy link
Member

mattab commented Jan 23, 2014

Thanks for the Pull request & fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants