Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v1.1.1 incorrectly displayed a warning about bad superuser name #2024

Closed
anonymous-matomo-user opened this issue Jan 16, 2011 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone

Comments

@anonymous-matomo-user
Copy link

The update to piwik 1.1.1 displayed this message:

--------------------8<--------------------
Warning messages:

Superuser login name "daniel-faber" is no longer a valid format. The login must be between 3 and 100 characters long and contain only letters, numbers, or the characters '_' or '-' or '.' or '@' Edit your config/config.ini.php to change it.
--------------------8<--------------------

This doesn't make sense since my user name 'daniel-faber' observes the mentioned rules.

My small analysis showed that the user name gets checked by Piwik::checkValidLoginString($userLogin), where it is matched against this regexp: /^[A-Za-z0-9_.-@]*$/

This is not what the warning message says because '.-@' is interpreted as the range from '.' to '@' and not as the three characters '.', '-', and '@'. To fix this, just replace the regexp with /^[A-Za-z0-9_.@-]*$/

I did not test it, but I think it will work.

@robocoder
Copy link
Contributor

fixed in trunk; dupe of #1762

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 1.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

2 participants