Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a new segment that has some visits will show 2 notifications instead of 1 #20222

Closed
mattab opened this issue Jan 17, 2023 · 5 comments · Fixed by #20465
Closed

Creating a new segment that has some visits will show 2 notifications instead of 1 #20222

mattab opened this issue Jan 17, 2023 · 5 comments · Fixed by #20465
Assignees
@sgiehl
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Milestone
4.14.0

Comments

@mattab
Copy link
Member

mattab commented Jan 17, 2023

After creating a new segment on Cloud, that matches some visits, then we see this:

image

Instead, we would only expect the blue notification?

Is this maybe a regression?
Can we confirm that we have a uI test for this and whether it shows this?
@mattab mattab added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jan 17, 2023
@sgiehl
Copy link
Member

sgiehl commented Jan 17, 2023 •
edited

The second message should actually only be shown for segments that aren't stored in the database.
@mattab does the segment value contain any special chars maybe?

@mattab
Copy link
Member Author

mattab commented Jan 17, 2023

It doesn't contain special chars:

image

@sgiehl
Copy link
Member

sgiehl commented Jan 18, 2023

Wondering if this might be related to #20060

@sgiehl sgiehl removed the To Triage An issue awaiting triage by a Matomo core team member label Feb 9, 2023
@mattab
Copy link
Member Author

mattab commented Mar 12, 2023

as I can still reproduce this in our company account, I suppose this applies to all Cloud customers, which could have a big impact, so adding to 4.x to fix?
reproduced here today: https://web.innocraft.cloud/index.php?module=CoreHome&action=index&idSite=12&period=month&date=today&updated=1#?period=month&date=today&category=Dashboard_Dashboard&subcategory=1&segment=countryName%3D%3DFrance

we would expect only the blue notification and not the red one

@mattab mattab added this to the 4.14.0 milestone Mar 12, 2023
@sgiehl sgiehl self-assigned this Mar 14, 2023
@sgiehl
Copy link
Member

sgiehl commented Mar 14, 2023

I was actually not able to reproduce that on our company account, but I was able to reproduce that red message locally.
It seems to be caused by the SingleMetricView widget. That one directly queries the API. And if the API doesn't find an usable archive it may throw that exception. I'll prepare a fix for that.

@sgiehl sgiehl mentioned this issue Mar 14, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Milestone
4.14.0
Development

Successfully merging a pull request may close this issue.

Do not throw no archive exception for API requests triggered by the UI matomo-org/matomo
2 participants
@mattab @sgiehl