Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a little more durability around timezone handling #20203

Merged
merged 2 commits into from Jan 12, 2023

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Jan 12, 2023

Description:

These changes are to prevent an exception from being thrown if a site uses a timezone that isn't in the list of accepted PHP timezones. It's a follow-up to PR 20136.

Review

@snake14 snake14 added the Needs Review PRs that need a code review label Jan 12, 2023
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/PHPUnit/Unit/DateTest.php Outdated Show resolved Hide resolved
@snake14 snake14 requested a review from bx80 January 12, 2023 19:46
@bx80 bx80 merged commit 68682b7 into 4.x-dev Jan 12, 2023
@bx80 bx80 deleted the making-adjustment-to-istoday-change branch January 12, 2023 22:49
@sgiehl sgiehl added this to the 4.13.2 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants