Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings in PHP 8.2 #20182

Closed
Starker3 opened this issue Jan 9, 2023 · 1 comment · Fixed by #20192
Closed

Fix deprecation warnings in PHP 8.2 #20182

Starker3 opened this issue Jan 9, 2023 · 1 comment · Fixed by #20192
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Milestone
4.13.2

Comments

@Starker3
Copy link
Contributor

Starker3 commented Jan 9, 2023

Some of these might be fixed by #20177
This customer is running Matomo 4.13.0 and got the following deprecation warnings in the UI:

WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Insights.getMoversAndShakers, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSocials, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSocials, In CLI mode: false)
WARNING: \core\DataTable\Filter\ColumnCallbackDeleteRow.php(55): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\ColumnCallbackDeleteRow::$columnsToFilter is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSocials, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(38): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$offset is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSocials, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(39): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$limit is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSocials, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(40): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$keepSummaryRow is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSocials, In CLI mode: false)
WARNING: \core\DataTable\Filter\ReplaceSummaryRowLabel.php(45): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\ReplaceSummaryRowLabel::$newLabel is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSocials, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Insights.getMoversAndShakers, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(38): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$offset is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(39): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$limit is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(40): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$keepSummaryRow is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\DataTable\Filter\ReplaceSummaryRowLabel.php(45): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\ReplaceSummaryRowLabel::$newLabel is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Insights.getMoversAndShakers, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(38): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$offset is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(39): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$limit is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(40): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$keepSummaryRow is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\DataTable\Filter\ReplaceSummaryRowLabel.php(45): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\ReplaceSummaryRowLabel::$newLabel is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Referrers.getSearchEngines, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Insights.getMoversAndShakers, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: UserCountry.getCountry, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(38): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$offset is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: UserCountry.getCountry, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(39): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$limit is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: UserCountry.getCountry, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(40): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$keepSummaryRow is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: UserCountry.getCountry, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: Insights.getMoversAndShakers, In CLI mode: false)
WARNING: \core\Archive\DataCollection.php(123): Deprecated - Creation of dynamic property Piwik\Archive\DataCollection::$segment is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: UserCountry.getCountry, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(38): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$offset is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: UserCountry.getCountry, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(39): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$limit is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: UserCountry.getCountry, In CLI mode: false)
WARNING: \core\DataTable\Filter\Limit.php(40): Deprecated - Creation of dynamic property Piwik\DataTable\Filter\Limit::$keepSummaryRow is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: API, Action: getOverallMoversAndShakers, Method: UserCountry.getCountry, In CLI mode: false)
@Starker3 Starker3 added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jan 9, 2023
@bx80
Copy link
Contributor

bx80 commented Jan 9, 2023

Thanks passing on this feedback @Starker3, this issue has now been added to the current sprint.

@bx80 bx80 removed the To Triage An issue awaiting triage by a Matomo core team member label Jan 9, 2023
@mattab mattab added this to the 4.13.2 milestone Jan 10, 2023
@bx80 bx80 mentioned this issue Jan 10, 2023
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title Deprecation warnings in PHP 8.2 Fix deprecation warnings in PHP 8.2 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Milestone
4.13.2
Development

Successfully merging a pull request may close this issue.

Fix for PHP 8.2 deprecation warnings in datatable filters matomo-org/matomo
3 participants
@mattab @Starker3 @bx80