Fix failing ArchiveCron test #20178
Merged
Fix failing ArchiveCron test #20178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
bx80
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- Tests were added if useful/possible
- None Reviewed for breaking changes
- n/a Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
justinvelluppillai
pushed a commit
that referenced
this pull request
Jan 12, 2023
* remove incorrect contructor parameters for SegmentArchiving class * Esnure segments are archived for the correct years in tests
justinvelluppillai
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Starting 2023 one of the tests started to fail. The problem is, that the segments were not archived anymore for the year the tests are using. Adjusting the archiving parameter fixed that.
While looking for the reason of the failure, I also found a few places where an incorrect constructor parameter was provided for
SegmentArchiving. It expects as first parameter the number of years it should process new segments for when processing them from beginning of time.Seem that used to be the value of the configuration for from when to processes segments.
Review