Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP8.2 Deprecation Warning on module install #20176

Closed
Entrepreneur-AJ opened this issue Jan 9, 2023 · 2 comments · Fixed by #20177
Closed

Fix PHP8.2 Deprecation Warning on module install #20176

Entrepreneur-AJ opened this issue Jan 9, 2023 · 2 comments · Fixed by #20177
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@Entrepreneur-AJ
Copy link

Expected Behavior

Plugin should download with no warnings

Current Behavior

Plugin downloads but warning banner is displayed:
WARNING: /core/Url.php(599): Deprecated - Use of "self" in callables is deprecated - Matomo 4.13.0 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: Marketplace, Action: installPlugin, In CLI mode: false)

Possible Solution

Steps to Reproduce (for Bugs)

Context

Your Environment

  • Matomo Version: 4.13.0
  • PHP Version: 8.2.1 (Litespeed version)
  • Server Operating System: Fedora 37
  • Additionally installed plugins:
  • Browser: Librewolf (Security Paranoid Firefox)
  • Operating System: Fedora 37
@Entrepreneur-AJ Entrepreneur-AJ added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jan 9, 2023
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jan 9, 2023
@sgiehl
Copy link
Member

sgiehl commented Jan 9, 2023

Hi @Entrepreneur-AJ
Thanks for creating this issue. I'll prepare a PR to fix it.

@sgiehl sgiehl added this to the 4.13.1 milestone Jan 9, 2023
@sgiehl sgiehl self-assigned this Jan 9, 2023
sgiehl added a commit that referenced this issue Jan 9, 2023
justinvelluppillai added a commit that referenced this issue Jan 11, 2023
* Fix deprecation notice on PHP 8.2

fixes #20176

* fix deprecations in truncate filter

* fix deprecations in customvisitdimension

* fix deprecations in datacollection

* fix deprecations in archiver

Co-authored-by: Justin Velluppillai <justin@innocraft.com>
@justinvelluppillai justinvelluppillai changed the title [PHP8.2] Deprecation Warning on module install. Fix PHP8.2 Deprecation Warning on module install Jan 12, 2023
@MatomoForumNotifications

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/self-is-depreciated/53752/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants