Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable segmented visits log feature for product reports #20175

Merged
merged 2 commits into from Jan 16, 2023
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 9, 2023

Description:

fixes #20153

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 9, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jan 9, 2023
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me, the segmented visits log row action is now available for product reports. A few of the system tests need updating as this change has added a segment field to the API output, once that's done this looks ready to merge 👍

@bx80 bx80 removed the Needs Review PRs that need a code review label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants