Trying to improve the accuracy of the isToday method #20136

Description:

Thomas noticed that the Date->isToday() method was producing inconsistent results when dealing with multiple time zones. This is an effort to improve that accuracy.

Review

• [ ] Functional review done
• [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done
• [ ] Wording review done
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@snake14 @bx80 I believe this change actually caused a regression the other day in funnels plugin? Maybe we need to revert it?

@snake14 @bx80 I believe this change actually caused a regression the other day in funnels plugin? Maybe we need to revert it?

Yeah. This would probably have a similar issue with sites that use UTF-5 type time zones. I can see if I can come up with a workaround.

@tsteur @bx80 I just created a new PR with a proposed fix so that this PR won't need to be reverted.