@snake14 opened this Pull Request on December 23rd 2022 Contributor

Description:

Thomas noticed that the Date->isToday() method was producing inconsistent results when dealing with multiple time zones. This is an effort to improve that accuracy.

Review

@github-actions[bot] commented on December 30th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@tsteur commented on January 11th 2023 Member

@snake14 @bx80 I believe this change actually caused a regression the other day in funnels plugin? Maybe we need to revert it?

@snake14 commented on January 11th 2023 Contributor

@snake14 @bx80 I believe this change actually caused a regression the other day in funnels plugin? Maybe we need to revert it?

Yeah. This would probably have a similar issue with sites that use UTF-5 type time zones. I can see if I can come up with a workaround.

@snake14 commented on January 12th 2023 Contributor

@tsteur @bx80 I just created a new PR with a proposed fix so that this PR won't need to be reverted.

This Pull Request was closed on January 11th 2023
Powered by GitHub Issue Mirror