Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct submit button text when editing/adding a scheduled report #20132

Merged
merged 2 commits into from Dec 22, 2022
Merged

Use the correct submit button text when editing/adding a scheduled report #20132

merged 2 commits into from Dec 22, 2022

Conversation

diosmosis
Copy link
Member

Description:

The condition is flipped in the code, currently.

Review

@diosmosis diosmosis added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 21, 2022
@diosmosis diosmosis added this to the 5.0.0 milestone Dec 21, 2022
@sgiehl sgiehl merged commit f23c38f into 5.x-dev Dec 22, 2022
@sgiehl sgiehl deleted the vue-correct-submit-button-text-scheduledreports branch December 22, 2022 08:29
@justinvelluppillai justinvelluppillai changed the title [Vue] make sure to use the correct submit button text when editing/adding a scheduled report Make sure to use the correct submit button text when editing/adding a scheduled report Jan 12, 2023
@sgiehl sgiehl changed the title Make sure to use the correct submit button text when editing/adding a scheduled report Use the correct submit button text when editing/adding a scheduled report May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl