Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract database specific helper methods to adapters #20112

Closed
wants to merge 3 commits into from

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Dec 16, 2022

Description:

Fixes #19648

Moves all MySQL specific code from core/Db, core/DbHelper and all classes under core/Db/ to the database adapter classes core/Adapter/Pdo/Mysql, core/Adapter/Mysqli and a new shared class core/Adapter/MysqlAdapterCommon for methods common for both.

Updates for tracker Db classes core/Tracker/Db, core/Tracker/Db/Pdo/Mysql and core/Tracker/Db/Mysqli are also included.

The overall objective of these changes is to be able to add a new core/Db/Adapter/Pdo/[some new db], core/Db/Schema/[some new db] and core/Tracker/Db/Pdo/[some new db] where 'some new db' supports prima facie MySQL style queries but has a different underlying architecture with differences in schema, indices, key type, engine type, error codes and session variables.

The previous branch suffered from the dreaded submodules 'not our ref' error so this a replacement branch/PR

Review

@bx80 bx80 added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Dec 16, 2022
@bx80 bx80 added this to the 5.0.0 milestone Dec 16, 2022
@bx80 bx80 self-assigned this Dec 16, 2022
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Dec 31, 2022
@mattab mattab added the 5.0.0 label Jan 4, 2023
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Feb 16, 2023
@michalkleiner michalkleiner modified the milestones: 5.0.0, 5.1.0 Jun 6, 2023
@sgiehl sgiehl added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Jul 10, 2023
@mattab mattab removed the 5.0.0 label Aug 4, 2023
@bx80 bx80 removed the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Oct 1, 2023
@bx80
Copy link
Contributor Author

bx80 commented Oct 1, 2023

Closing due to age.

@bx80 bx80 closed this Oct 1, 2023
@sgiehl sgiehl deleted the m19648-abstract-db-helpers-new branch January 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract database specific helper methods to PDO adapter
4 participants