Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various UI tests fail with TypeError: Cannot read property 'join' of undefined in page-renderer.js #20103

Closed
tsteur opened this issue Dec 13, 2022 · 1 comment · Fixed by #20104
Closed

Various UI tests fail with TypeError: Cannot read property 'join' of undefined in page-renderer.js #20103

tsteur opened this issue Dec 13, 2022 · 1 comment · Fixed by #20104
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.13.1

Comments

@tsteur
Copy link
Member

tsteur commented Dec 13, 2022

Noticed this eg in https://app.travis-ci.com/github/matomo-org/matomo/jobs/591094114

image

Seems it doesn't impact the tests but it's confusing as it's not clear if the test failed or succeeded etc.
@tsteur tsteur added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. To Triage An issue awaiting triage by a Matomo core team member labels Dec 13, 2022
@peterhashair peterhashair mentioned this issue Dec 13, 2022
Merged
11 tasks
@peterhashair
Copy link
Contributor

@tsteur quickly did a PR. Seems fixed it.

@peterhashair peterhashair removed the To Triage An issue awaiting triage by a Matomo core team member label Dec 15, 2022
@peterhashair peterhashair added this to the 4.13.1 milestone Dec 15, 2022
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.13.1
Development

Successfully merging a pull request may close this issue.

remove catch in UI tests matomo-org/matomo
3 participants
@tsteur @sgiehl @peterhashair