@tsteur opened this Pull Request on December 13th 2022 Member

Description:

Since merging https://github.com/matomo-org/matomo/pull/20094 and https://github.com/matomo-org/matomo/pull/20090 sparklines load a lot faster and the comparison feature is now usable for most dates. However, when comparing for example two years then evolution graph is still slow and sometimes after minutes of loading even times out.

This change now uses the same logic to also speed up evolution graphs and makes sure that both sparklines and evolution graphs use the same periods.

  • When now viewing a large range, the evolution graph may switch from day period to week or month or year to needing to fetch less archives.
  • When now comparing date ranges, the evolution graph may switch from day period to week or month or year to needing to fetch less archives.
  • When comparing periods, for consistency both sparklines and evolution graphs will now behave the same and show the evolution over the selected range instead of sparklines showing historical evolution.

Besides this we're now also:

  • Disabling selecting period in evolution graph when comparison feature is used as it was never working. This refs https://github.com/matomo-org/matomo/issues/17582 . Once merged I'll adjust the issue to describe that we disabled it for now and mention we need to enable this feature and make it work as part of that issue.

Review

@tsteur commented on December 20th 2022 Member

Thanks @sgiehl 👍

This Pull Request was closed on December 20th 2022
Powered by GitHub Issue Mirror