@Uma5 opened this Pull Request on January 15th 2014

Now when android devices access the website they will be given the option to download the app from the google play store.

@mattab commented on January 15th 2014 Member

Nice new feature!

here is the code review:

  • remove readme
  • move file jquery.smartbanner.js one directory up
  • there is an image referenced in the CSS file, called url('dark_background_stripes.gif');
    I suggest we rename this in the css to: url('plugins/CoreHome/images/smartbanner-bg-strips.gif')
  • move the image from CoreHome/javascripts/jasny-jquery.smartbanner-26a74cb/dark_background_stripes.gif to this new place
  • Remove test file windowstest.html

Thanks for your contribution!

@sgiehl commented on January 15th 2014 Member

As it is a third party library, I would suggest to move the smartbanner stuff to libs/jquery directory instead.

@pebosi commented on January 15th 2014 Contributor

My 2c: This is adding another "useless" library. Would'nt it enough to link to the app stores in admin settings? I don't like to pop this bar up every time i use piwik on ipad/android. the webinterface is working really well on ipad/android without the app.

@mattab commented on January 15th 2014 Member

It won't popup everytime: it will only popup once, when you use Android phone. Then if you close it it is stored as cookie and wont be shown again.

Also It is only displayed on the login screen so it won't disturb the dashboard analytics experience.

This Pull Request was closed on January 15th 2014
Powered by GitHub Issue Mirror