New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an android smart app promo bar #201
Conversation
Nice new feature! here is the code review:
Thanks for your contribution! |
As it is a third party library, I would suggest to move the smartbanner stuff to libs/jquery directory instead. |
My 2c: This is adding another "useless" library. Would'nt it enough to link to the app stores in admin settings? I don't like to pop this bar up every time i use piwik on ipad/android. the webinterface is working really well on ipad/android without the app. |
…e banner remains hidden so if you click close or view you won't see the banner again. This is in response to some users saying this would be their preference.
It won't popup everytime: it will only popup once, when you use Android phone. Then if you close it it is stored as cookie and wont be shown again. Also It is only displayed on the login screen so it won't disturb the dashboard analytics experience. |
Added an android smart app promo bar Kuddos for the pull request!
Now when android devices access the website they will be given the option to download the app from the google play store.