Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an android smart app promo bar #201

Merged
merged 5 commits into from Jan 15, 2014
Merged

Added an android smart app promo bar #201

merged 5 commits into from Jan 15, 2014

Conversation

Uma5
Copy link

@Uma5 Uma5 commented Jan 15, 2014

Now when android devices access the website they will be given the option to download the app from the google play store.

@mattab
Copy link
Member

mattab commented Jan 15, 2014

Nice new feature!

here is the code review:

  • remove readme
  • move file jquery.smartbanner.js one directory up
  • there is an image referenced in the CSS file, called url('dark_background_stripes.gif');
    I suggest we rename this in the css to: url('plugins/CoreHome/images/smartbanner-bg-strips.gif')
  • move the image from CoreHome/javascripts/jasny-jquery.smartbanner-26a74cb/dark_background_stripes.gif to this new place
  • Remove test file windowstest.html

Thanks for your contribution!

@sgiehl
Copy link
Member

sgiehl commented Jan 15, 2014

As it is a third party library, I would suggest to move the smartbanner stuff to libs/jquery directory instead.

@pebosi
Copy link
Contributor

pebosi commented Jan 15, 2014

My 2c: This is adding another "useless" library. Would'nt it enough to link to the app stores in admin settings? I don't like to pop this bar up every time i use piwik on ipad/android. the webinterface is working really well on ipad/android without the app.

Uma added 3 commits January 16, 2014 10:06
…e banner remains hidden so if you click close or view you won't see the banner again. This is in response to some users saying this would be their preference.
@mattab
Copy link
Member

mattab commented Jan 15, 2014

It won't popup everytime: it will only popup once, when you use Android phone. Then if you close it it is stored as cookie and wont be shown again.

Also It is only displayed on the login screen so it won't disturb the dashboard analytics experience.

mattab pushed a commit that referenced this pull request Jan 15, 2014
Added an android smart app promo bar
Kuddos for the pull request!
@mattab mattab merged commit 36fd057 into matomo-org:master Jan 15, 2014
mattab added a commit that referenced this pull request Jan 15, 2014
mattab added a commit that referenced this pull request Jan 15, 2014
@Findus23 Findus23 mentioned this pull request Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants