Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Nonce and Token exception message #20099

Merged
merged 7 commits into from Dec 20, 2022

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Updated Nonce and Token exception message since the current message just gives the error and do not specify how it can be resolved by a retry.

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Dec 13, 2022
@sgiehl
Copy link
Member

sgiehl commented Dec 14, 2022

@AltamashShaikh any specific reason for updating the default TTL from 5 to 10 minutes?
Also did you check if the translation keys that had been used before might now be unused at all? If so, we should remove them.

@AltamashShaikh
Copy link
Contributor Author

@AltamashShaikh any specific reason for updating the default TTL from 5 to 10 minutes? Also did you check if the translation keys that had been used before might now be unused at all? If so, we should remove them.

For increasing TTL there was a slack conversation around it, shared the conversation link with you.
Ill check if the translation keys are being used anywhere or not and if not will remove it

@AltamashShaikh
Copy link
Contributor Author

@sgiehl Removed General_ExceptionInvalidToken key as its not being used anywhere, whereas General_ExceptionNonceMismatch is being used in few plugins as I searched

@AltamashShaikh
Copy link
Contributor Author

@sgiehl Reverted nonce ttl code, since it needs to be updated in GAImporter plugin only

lang/en.json Outdated Show resolved Hide resolved
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Dec 15, 2022
@sgiehl sgiehl merged commit f305f16 into 4.x-dev Dec 20, 2022
@sgiehl sgiehl deleted the update-nonce-and-token-esception-message branch December 20, 2022 10:35
@sgiehl sgiehl added this to the 4.13.1 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants