@AltamashShaikh
Description:
Updated Nonce and Token exception message since the current message just gives the error and do not specify how it can be resolved by a retry.
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@sgiehl
@AltamashShaikh any specific reason for updating the default TTL from 5 to 10 minutes?
Also did you check if the translation keys that had been used before might now be unused at all? If so, we should remove them.
@AltamashShaikh any specific reason for updating the default TTL from 5 to 10 minutes? Also did you check if the translation keys that had been used before might now be unused at all? If so, we should remove them.
For increasing TTL there was a slack conversation around it, shared the conversation link with you.
Ill check if the translation keys are being used anywhere or not and if not will remove it
@sgiehl Removed General_ExceptionInvalidToken key as its not being used anywhere, whereas General_ExceptionNonceMismatch is being used in few plugins as I searched
@sgiehl Reverted nonce ttl code, since it needs to be updated in GAImporter plugin only