@AltamashShaikh opened this Pull Request on December 13th 2022 Contributor

Description:

Updated Nonce and Token exception message since the current message just gives the error and do not specify how it can be resolved by a retry.

Review

@sgiehl commented on December 14th 2022 Member

@AltamashShaikh any specific reason for updating the default TTL from 5 to 10 minutes?
Also did you check if the translation keys that had been used before might now be unused at all? If so, we should remove them.

@AltamashShaikh commented on December 14th 2022 Contributor

@AltamashShaikh any specific reason for updating the default TTL from 5 to 10 minutes? Also did you check if the translation keys that had been used before might now be unused at all? If so, we should remove them.

For increasing TTL there was a slack conversation around it, shared the conversation link with you.
Ill check if the translation keys are being used anywhere or not and if not will remove it

@AltamashShaikh commented on December 14th 2022 Contributor

@sgiehl Removed General_ExceptionInvalidToken key as its not being used anywhere, whereas General_ExceptionNonceMismatch is being used in few plugins as I searched

@AltamashShaikh commented on December 15th 2022 Contributor

@sgiehl Reverted nonce ttl code, since it needs to be updated in GAImporter plugin only

This Pull Request was closed on December 20th 2022
Powered by GitHub Issue Mirror