Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update our github actions to not use set-output #20095

Closed
sgiehl opened this issue Dec 12, 2022 · 1 comment · Fixed by #20127
Closed

Update our github actions to not use set-output #20095

sgiehl opened this issue Dec 12, 2022 · 1 comment · Fixed by #20127
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.13.2

Comments

@sgiehl
Copy link
Member

sgiehl commented Dec 12, 2022

Most of our actions are currently using set-output. As this one is deprecated, we need to update the actions.

Warning: The `set-output` command is deprecated 
and will be disabled soon. Please upgrade to using 
Environment Files.

For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

set-output will fail after June 1st 2023

We should already change that on 4.x-dev branch, to avoid the action to fail on that branch as long as it may still be LTS.
@sgiehl sgiehl added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 12, 2022
@sgiehl sgiehl added this to the 4.13.2 milestone Dec 12, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Dec 13, 2022 •
edited

we maybe also need up checkout@v2 to v3, seems like Github Action only accept node 11 +
Consider maybe reopen this PR https://github.com/matomo-org/matomo/pull/19874/files

@sgiehl sgiehl modified the milestones: 4.13.2, 4.13.1 Dec 20, 2022
@sgiehl sgiehl self-assigned this Dec 20, 2022
@sgiehl sgiehl mentioned this issue Dec 20, 2022
Merged
11 tasks
@mattab mattab added the 4.13.1 label Jan 4, 2023
@justinvelluppillai justinvelluppillai modified the milestones: 4.13.1, 4.13.2 Jan 11, 2023
@sgiehl sgiehl mentioned this issue Jan 12, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.13.2
Development

Successfully merging a pull request may close this issue.

Update github actions matomo-org/matomo
4 participants
@mattab @justinvelluppillai @sgiehl @peterhashair