@tsteur opened this Pull Request on December 12th 2022 Member

Since we merged https://github.com/matomo-org/matomo/pull/20090 when comparing dates we no longer need to force day periods when comparing dates since we're ensuring the correct period is being used in the Sparklines visualisation.

Deployed that PR on production and noticed the URL looks like:

image

Even though both periods given are week it falsely chose day for the initial period. Which not only made it compare wrong data but also got very slow (since it had to load 365 days which is slower than 52 weeks).

This PR fixes it and now looks like

image

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

This Pull Request was closed on December 12th 2022
Powered by GitHub Issue Mirror