Don't force using day period for sparkline when comparing to ensure it compares correct periods and is fast #20094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we merged #20090 when comparing dates we no longer need to force day periods when comparing dates since we're ensuring the correct period is being used in the Sparklines visualisation.
Deployed that PR on production and noticed the URL looks like:
Even though both periods given are week it falsely chose day for the initial period. Which not only made it compare wrong data but also got very slow (since it had to load 365 days which is slower than 52 weeks).
This PR fixes it and now looks like
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review