New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up sparklines when larger periods are selected and improve detection of trends as well as fix comparison of dates #20090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bx80
reviewed
Dec 11, 2022
plugins/CoreVisualizations/Visualizations/Sparklines/SparklinePeriodSelector.php
Show resolved
Hide resolved
bx80
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this on different date ranges and comparisons, the sparkline periods behave as expected with weeks being chosen over days for ranges over six months and months being chosen for ranges over two years. Should be a nice performance boost 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests updated Tests were added if useful/possible
- Reviewed for breaking changes
- n/a Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
Thanks @bx80 for reviewing 👍 |
tsteur
added a commit
that referenced
this pull request
Dec 12, 2022
…t compares correct periods Since we merged #20090 when comparing dates we no longer need to force day periods when comparing date ranges since we're ensuring the correct period is being used in the Sparklines visualisation.
11 tasks
11 tasks
justinvelluppillai
added
c: Performance
For when we could improve the performance / speed of Matomo.
and removed
Needs Review
PRs that need a code review
labels
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Review