Add countdown redirection to User Invite error page #20082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bx80
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
Tests well for me 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- n/a Tests were added if useful/possible
- none Reviewed for breaking changes
- Not needed Developer changelog updated if needed
- Not needed Documentation added if needed
- n/a Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This addition adds a countdown redirection to the User invite error page. If a user clicked on an expired or invalid invite link then they would be redirected back to the login page of the Matomo instance. This helps the user back out of the exception error page.
I've also written the translation of the error in more plain language. This provides a couple of clear reasons which they can attempt to resolve.
An additional change was to remove the
Login_InvalidUsernameEmailtranslation when theacceptInvitationcontroller couldn't find a user. This response might be a bit confusing as it is really the technical downstream reason for failure and not really actionable by the user.Review