Adds new action to build woff2 font file #20081
Conversation
sgiehl
added
c: Tests & QA
There was a problem hiding this comment.
Other than the deprecation warning, I can't see any issues with this 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- This removes a test 😉 Tests were added if useful/possible
- Reviewed for breaking changes
- n/a Developer changelog updated if needed
- not needed Documentation added if needed
- not needed Existing documentation updated if needed
| echo ::set-output name=islocalbranch::$BASE == $GITHUB_REPOSITORY | ||
| echo ::set-output name=branch::$REF | ||
| echo ::set-output name=base::$BASE_SHA |
There was a problem hiding this comment.
The detailed action log is showing a deprecation warning for the set-output command:
Warning: The `set-output` command is deprecated
and will be disabled soon. Please upgrade to using
Environment Files.
For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
set-output will fail after June 1st 2023, it looks straight forward to update to the new syntax, so maybe it would be good to do that now?
There was a problem hiding this comment.
Yes I know. But I didn't have time to check what exactly would need to be changed for that.
We will need to update that for all our actions, so will merge this as it is for now and we can adjust all our actions then at once for the new syntax. I'll create an issue for that.
justinvelluppillai
added
the
not-in-changelog
Description:
We previously were running a test (on travis) to check if the woff2 file is still up to date.
It should be faster and smarter to run a github action instead that works similar as the vue build action.
So instead of having to install woff2 for running tests, the github action will now only try to check and update the woff2 file if the ttf font file had been updated in a PR.
@justinvelluppillai putting this into a 4.13 milestone as it should be fine to merge to 4.x-dev as it doesn't contain any relevant code changes that might affect Matomo, but will avoid some additional code requirements for the new github test action.
Review