Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Http class header parse error #20078

Merged
merged 2 commits into from Dec 7, 2022
Merged

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Dec 5, 2022

Description:

Fixes #20077

When a non-boolean response is received by the core/Http::sendHttpRequestBy() method and no redirect header is found the explode() method attempts to execute against a string instead of an array causing a fatal error.

This PR changes the default value for the header variable in this code block from string to array.

Review

@bx80 bx80 added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 5, 2022
@bx80 bx80 added this to the 4.13.2 milestone Dec 5, 2022
@bx80 bx80 self-assigned this Dec 5, 2022
core/Http.php Outdated Show resolved Hide resolved
@bx80 bx80 added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 6, 2022
@sgiehl sgiehl merged commit d1eaaca into 4.x-dev Dec 7, 2022
@sgiehl sgiehl deleted the m20077-http-header-parse branch December 7, 2022 08:39
@sgiehl sgiehl modified the milestones: 4.13.2, 4.13.1 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error in tour when detecting consent manager
3 participants