Fix Textarea when providing empty line, and prevent broken settings page #20070
Conversation
There was a problem hiding this comment.
Thanks @alcalyn for contributing this PR. That's very appreciated.
I was able to reproduce the problem you described. Your fixes should indeed solved that 💯
I left one suggestion, that needs to be applied. In addition we have commited the built vue files to git. So to finish the PR it would be needed to built the files.
For that you may need to run an npm install to fetch the related dependencies. Afterwards it should be possible to run ./console vue:build to build the vue files.
If you aren't able to build the files, let me know. I can also do that once the PR was merged.
| } catch (e) { | ||
| // Prevent page breaking on unexpected modelValue type | ||
| console.error(e); | ||
| return []; |
There was a problem hiding this comment.
The method is supposed to return a string.
| return []; | |
| return ''; |
alcalyn
force-pushed
the
fix-settings-page
branch
from
0d97ae0
to
e39a497
Compare
|
Thanks for the help, fixed it and vue files rebuilt. |
Description:
When addind an empty line in a TextArea in "General settings" page, i.e in ips whitelist:
The array value is stored as
{"0": "1.1.1.1", "2": "2.2.2.2"}because of the array_filter.Also the
validateis called before thetransform, which seems to be expected, but makes the error uncached.The impact is the "General settings" page throw an error and stop rendering, so all plugin settings after the error are not rendered, then the page does not display all plugins settings. This PR also catch this js error in case other plugins have the same error, so that all plugins settings are displayed.
Review