@alcalyn opened this Pull Request on December 1st 2022 Contributor

Description:

When addind an empty line in a TextArea in "General settings" page, i.e in ips whitelist:

1.1.1.1

2.2.2.2

The array value is stored as {"0": "1.1.1.1", "2": "2.2.2.2"} because of the array_filter.

Also the validate is called before the transform, which seems to be expected, but makes the error uncached.

The impact is the "General settings" page throw an error and stop rendering, so all plugin settings after the error are not rendered, then the page does not display all plugins settings. This PR also catch this js error in case other plugins have the same error, so that all plugins settings are displayed.

Review

@alcalyn commented on December 5th 2022 Contributor

Thanks for the help, fixed it and vue files rebuilt.

This Pull Request was closed on December 5th 2022
Powered by GitHub Issue Mirror