@mattab opened this Issue on November 29th 2022 Member

expected notification:

image

we reproduced on Cloud this wasn't displayed after creating a segment.
This may be a regression in core?

@heurteph-ei commented on November 29th 2022

There was another issue about this notification in case of empty report (because no data, not because not processed), but impossible to find it again... 🤔

@justinvelluppillai commented on November 29th 2022 Member

Let's make sure we add UI tests once this is resolved so we can catch if it regresses again

@sgiehl commented on November 30th 2022 Member

I'm actually not able to reproduce that problem locally. When browser archiving is disabled and I create a new segment the notification is shown. And there is a UI test for exact this case:

https://github.com/matomo-org/matomo/blob/a81d55323a9c9a80694609ab131c9ce46f956f63/plugins/SegmentEditor/tests/UI/UnprocessedSegment_spec.js#L48-L61

result

The only change around that logic I could find is https://github.com/matomo-org/matomo/pull/18540

@peterhashair commented on November 30th 2022 Contributor

I can't reproduce this locally as well. Will try again today.

@justinvelluppillai commented on December 8th 2022 Member

@mattab are you still able to reproduce this issue and provide info about the steps?

@mattab commented on December 8th 2022 Member

@justinvelluppillai it can be reproduced on Cloud (in our instance), but i haven't reproduced on on-premise yet, but you had maybe reproduced it before? or maybe it's just an issue on Cloud

@mattab commented on January 4th 2023 Member

fyi reproduced today again on Cloud, created a random segment and there was no notification box:
image

@mattab commented on January 9th 2023 Member

Because the issue is only happening on Cloud, we will close it here, and Cloud team will investigate.

@mattab commented on January 9th 2023 Member

reproduced on demo2

@sgiehl commented on January 10th 2023 Member

Relevant config values that are e.g. used on demo2:

browser_archiving_disabled_enforce = 1
enable_create_realtime_segments = 0
enable_browser_archiving_triggering = 0
process_new_segments_from = "last60"
@bx80 commented on January 17th 2023 Contributor

I can recreate this on locally and on demo2 by creating a new segment which will not return any visits for the selected time period.

For example:

  1. Use a site with a day selected containing only visits between say 6am to 11pm
  2. Create a new segment "Site - time hour is not 3am"
  3. The segment unprocessed message will be shown because there are visits for this segment in the selected time period.
  4. Create a new segment "Site - time hours is 3am"
  5. The segment unprocessed message will not be shown because there are no visits for this segment in the selected time period.
  6. Change the time period to a whole year where there will be some visits at 3am, now the segment unprocessed message will be shown.

This is because of the code 'if no visits recorded, data will not appear, so don't show the message'

This is intentional behavior added as part of #12823, but it's potentially confusing as experienced users wouldn't expect a new segment to be 'ready' immediately and seems a bit inconsistent that the segment will sometimes show as unprocessed depending on the selected period.

Possible changes:

  1. Disable the check and always show the unprocessed message until the segment has been processed even if there will be no data for that time period.
  2. Show a discreet info message: "Hey this segment is new and probably hasn't been processed for all periods yet, but there is no segment data for this particular time period anyway, so we're showing you a blank report"
  3. Leave it as is and add some explanatory documentation somewhere (probably not very helpful as it would be hard to find in a search)
  4. Better ideas?

@mattab Do you have any preferences on how to proceed with this?

@mattab commented on January 17th 2023 Member

I'd go with 1) to make things consistent & simple, maybe?

@mattab commented on January 23rd 2023 Member

Closing due to complications to implement and not being worth it yet

This Issue was closed on January 23rd 2023
Powered by GitHub Issue Mirror