If the custom URL is set, check if is file protocol. #20056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build js |
sgiehl
reviewed
Nov 28, 2022
|
build js |
peterhashair
added
Needs Review
|
@peterhashair I would be awesome to also add some tests for that new config flag and custom file urls not being tracked |
|
@sgiehl I was trying to add tests, but it seems like Travis didn't allow swap protocol, any suggestions? |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
check current url checks
format alien code
update regex
|
@bx80 I've fixed the code and added some tests. This should be ready for a final review now. |
bx80
changed the title
bx80
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
File protocol handling tests well for me 👍
Only thing I noticed was that the count tracking events test is failing, this PR updated the count to 59, but there are 62 events in my local tests. This count is also wrong on 4.x-dev too so it might be my config?
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- Tests added Tests were added if useful/possible
- Reviewed for breaking changes
- n/a Developer changelog updated if needed
- n/a Documentation added if needed
- Existing documentation updated if needed
sgiehl
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #20049
If a custom URL is set, check if is file protocol.
Review