Matomo Pull Request #20056 - If the custom URL is set, check if is file protocol.

@peterhashair opened this Pull Request on November 27th 2022 Contributor

Fixes: #20049

If a custom URL is set, check if is file protocol.

[ ] Functional review done
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
[ ] Security review done
[ ] Wording review done
[ ] Code review done
[ ] Tests were added if useful/possible
[ ] Reviewed for breaking changes
[ ] Developer changelog updated if needed
[ ] Documentation added if needed
[ ] Existing documentation updated if needed

@peterhashair commented on November 27th 2022 Contributor

build js

@peterhashair commented on November 29th 2022 Contributor

build js

@sgiehl commented on December 1st 2022 Member

@peterhashair I would be awesome to also add some tests for that new config flag and custom file urls not being tracked

@peterhashair commented on December 11th 2022 Contributor

@sgiehl I was trying to add tests, but it seems like Travis didn't allow swap protocol, any suggestions?

@github-actions[bot] commented on December 26th 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@sgiehl commented on January 9th 2023 Member

@bx80 I've fixed the code and added some tests. This should be ready for a final review now.

This Pull Request was closed on January 15th 2023

If the custom URL is set, check if is file protocol. #20056