Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file:// protocol exclude option JS in tracker doesn't consider custom URL #20049

Closed
tsteur opened this issue Nov 24, 2022 · 1 comment · Fixed by #20056
Closed

file:// protocol exclude option JS in tracker doesn't consider custom URL #20049

tsteur opened this issue Nov 24, 2022 · 1 comment · Fixed by #20056
Assignees
@sgiehl
Labels
c: Privacy For issues that impact or improve the privacy. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Nov 24, 2022

The feature #17017 was added in https://github.com/matomo-org/matomo/pull/19835/files

In this change we're using location.protocol. However, we would need to use the tracker method getCurrentUrl() and check whether the protocol is file for configCustomUrl || locationHrefAlias. That's because a user can overwrite the URL via setCustomUrl(). If the set custom URL isn't of protocol file, then we could still track it. Not sure if there would be any other side effects otherwise like the referrer may be still file://.
@tsteur tsteur added c: Privacy For issues that impact or improve the privacy. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Nov 24, 2022
@peterhashair peterhashair mentioned this issue Nov 27, 2022
Merged
11 tasks
@peterhashair peterhashair linked a pull request Nov 27, 2022 that will close this issue
If the custom URL is set, check if is file protocol. #20056
Merged
11 tasks
@justinvelluppillai
Copy link
Contributor

Small point but we also have function getProtocolScheme(url) that would be useful to use

@sgiehl sgiehl added this to the 5.0.0 milestone Jan 9, 2023
@sgiehl sgiehl self-assigned this Jan 9, 2023
@sgiehl sgiehl closed this as completed Feb 7, 2023
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Privacy For issues that impact or improve the privacy. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

If the custom URL is set, check if is file protocol. matomo-org/matomo
3 participants
@tsteur @justinvelluppillai @sgiehl