Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve layout of measurable type selection #20033

Merged
merged 3 commits into from Dec 1, 2022
Merged

Improve layout of measurable type selection #20033

merged 3 commits into from Dec 1, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 21, 2022

Description:

fixes #20020

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 21, 2022
@sgiehl sgiehl added this to the 5.0.0 milestone Nov 21, 2022
@sgiehl sgiehl marked this pull request as ready for review November 21, 2022 12:46
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Nov 29, 2022
justinvelluppillai
justinvelluppillai approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Did you consider modifying the screenshot to actually show over two lines, which would prevent this regressing in future?

@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label Nov 29, 2022
@sgiehl sgiehl removed the Stale The label used by the Close Stale Issues action label Nov 30, 2022
@sgiehl
Copy link
Member Author

sgiehl commented Nov 30, 2022

@justinvelluppillai I actually didn't. Will adjust the test and merge once it succeeds

@sgiehl sgiehl force-pushed the m20020 branch 2 times, most recently from 1c015c5 to 684a844 Compare December 1, 2022 08:46
@sgiehl sgiehl merged commit 5446a97 into 5.x-dev Dec 1, 2022
@sgiehl sgiehl deleted the m20020 branch December 1, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @justinvelluppillai