Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two tooltips may be shown when reloading visits log via shortcut #20024

Open
tsteur opened this issue Nov 17, 2022 · 4 comments
Open

Two tooltips may be shown when reloading visits log via shortcut #20024

tsteur opened this issue Nov 17, 2022 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone
For Prioritization

Comments

@tsteur
Copy link
Member

tsteur commented Nov 17, 2022

I'm using the visits log. Hovering an action and seeing tooltip.
Then I press r to reload the page. Then some entries further down I see two tooltips.

Happens on latest Matomo . After doing a full reload shows nicely only one tooltip.

image
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Nov 17, 2022
@bx80
Copy link
Contributor

bx80 commented Nov 17, 2022

I can confirm this behavior. It seems like if there is a tooltip being displayed when an r reload is performed, the tooltip is not closed and will follow the mouse cursor until a full page reload is done. The r reload function might need to check and close any displayed tooltips before reloading.

@bx80 bx80 added this to the For Prioritization milestone Nov 17, 2022
@sgiehl
Copy link
Member

sgiehl commented Nov 22, 2022

@diosmosis this might possibly be a vue regression. The reload shortcut uses the loadPage event. That one imho should also handle the removal of no longer needed elements. Maybe calling something like require('piwik/UI').UIControl.cleanupUnusedControls(); would fix this.

@michalkleiner
Copy link
Contributor

#20624 might be slightly relevant, or the solution might be similar — to hide any other tooltips when opening a new one.

@diosmosis
Copy link
Member

Did some quick digging, looks like this might be caused by visitorActions.js. It sets up the tooltips, but it's just vanilla JS, so there's nothing that destroys them when the visitor log is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
5 participants
@diosmosis @michalkleiner @tsteur @sgiehl @bx80