New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to use type hinted parameters for API methods #20016
Conversation
6063d05
to
2e88e6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by adding type hints to API methods and using breakpoints to check that the correct get[type]Parameter request method is used.
I can't see any issues 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
- Existing documentation updated if needed
@bx80 Thanks for the review. I've now also added something to the changelog and also updated the code examples in the example plugins. In addition I've created a PR for the documentation, so the type hinting stuff is documented as well. |
Description:
fixes #19984
Review