Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use type hinted parameters for API methods #20016

Merged
merged 11 commits into from Dec 5, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 15, 2022

Description:

fixes #19984

Review

@sgiehl sgiehl added this to the 5.0.0 milestone Nov 15, 2022
@sgiehl sgiehl force-pushed the apitypehint branch 2 times, most recently from 6063d05 to 2e88e6b Compare November 25, 2022 16:51
@sgiehl sgiehl marked this pull request as ready for review December 1, 2022 13:55
@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 1, 2022
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by adding type hints to API methods and using breakpoints to check that the correct get[type]Parameter request method is used.

I can't see any issues 👍

@sgiehl
Copy link
Member Author

sgiehl commented Dec 2, 2022

@bx80 Thanks for the review. I've now also added something to the changelog and also updated the code examples in the example plugins. In addition I've created a PR for the documentation, so the type hinting stuff is documented as well.
Would you mind having another look at everything and merge it if its fine? Thx

@bx80 bx80 merged commit ffca8d3 into 5.x-dev Dec 5, 2022
@bx80 bx80 deleted the apitypehint branch December 5, 2022 00:21
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow API parameter type hints
2 participants