Improve GA/consent manager detection by not restricting to curl and caching result #20008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icit curl usage to getHTTPTransport(), code tidy and added additional comments
bx80
added
the
c: Performance
…required property, fixed mock and tests
justinvelluppillai
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Once the unused import is removed and @mattab gets back to us on the timeout (5s looks good to me) this looks good to merge 👍🏽
|
@bx80 Another suggestion for improvement: |
elabuwa
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes the Site Content Detector class to use lazy caching for detected site properties so that site content will only be checked at most once per week. A lower cache lifetime than four weeks was used so that existing Matomo users who add a content manager to their site can see the setup guide links within a few days.
Explicit curl usage has been replaced with
getHTTPTransport()as a parameter tosendHttpRequestBy()so that there is no restriction to just using curl, but invalid SSL certificates can still be ignored.Fixes #20000
(Remember to turn off development mode in config.ini.php for cache testing! 🙂 )
Review