hide widget when not found #20007
hide widget when not found #20007
Conversation
hide widget when not found
update hide to destroy
peterhashair
added
Needs Review
update from destroy to remove
|
@peterhashair did you check what happens if you e.g. create a dashboard for a site, that has goals created, add one of the goals widgets and switch to another site, that has no goals created. Afterwards you perform any action on the dashboard so the layout is saved. Is the goals widget then removed when switching back to the site where a goal actually exists? |
update remove to hide
There was a problem hiding this comment.
Hiding the widget worked well for me in testing 👍 I created a goals widget for site a, switched to site b and the widget was hidden, switching back to site a shows the widget again. Making a change to the dashboard while the widget was hidden (to trigger a save) didn't affect the widget reappearing when switching back to the original.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
- Existing documentation updated if needed
Description:
Fixes: #9969
hide widget when not found
Review